Short trills/mordents playback intervals fixed to major 2nds and cannot be changed

[mikeoas]

Issue type

Muse Sounds bug

Bug description

Playback of short trills and mordents using Muse Sounds always uses a major 2nd as the interval above/below, even when the default interval (diatonic) is selected. Trying to fix the interval to a minor/major 2nd does not work. (Does not affect playback with MS Basic/soundfonts.)

Steps to reproduce

1. Create new score with Muse Sounds instruments
2. Enter some notes
3. Add short trills or mordents to any of the notes
4. Press play
5. (Optional) In Properties -> Ornament, try modifying interval above/below from Auto (diatonic) to minor/major 2nd, before pressing play again

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/22620386/014c3f1d-5b14-4f54-9a86-96ff175d8db4

MuseScore Version

4.2.0-233521125, revision: github-musescore-musescore-eb8d33c

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

macOS 13.6 (Arch.: x86_64)

Additional context

Seemed to work as expected for previous release of MuseScore (version 4.1.1), so possibly a regression? Other ornaments (e.g. trills, turns) also still work properly, i.e. their intervals can be adjusted and played back correctly.

Soundfonts (MS Basic) plays back all ornaments (including short trills and mordents) as expected.

[DaddyLudwig]

I remember having this issue of mordents always being a major second apart even when the supposed Diatonic default is a semitone like way back in the beta of 4.0, it made things like Bach/Petzold Minuet in G sound really weird. Seems super odd that an issue fixed before 4.1 was released has now returned. Original issue: https://github.com/musescore/MuseScore/issues/14564

[bkunda]

Confirmed in 4.1.1 and 4.2 on macOS. What's interesting though is that I could only reproduce this with the oboe. Testing the same passage on flute, solo violin and piano renders:

• correct (diatonic) playback
• much faster playback speed (too fast, imo)

See video

@konradglas not sure if this is musesampler related? (Tested using 0.5.1 – I might need you to supply me with an earlier version to check regression status).

[mikeoas]

I do have an additional example of the short trills not working for instruments other than the oboe - from bar 307 (around 15:15) of this:

https://musescore.com/user/14072251/scores/10247233

where it can be heard in the bassoon, flute and clarinet. (#20557 also happens here at the end.) I also have a render of that section on audio.com using MuseScore 4.1.1 and (presumably?) the previous version of musesampler, which did render correct diatonic playback:

https://audio.com/michael-andrew-seaton/audio/brahms-handel-variations-op-24-variation-19

[konradglas]

@RomanPudashkin MuseSampler only gets ms_NoteArticulation_MordentWhole when it should get ms_NoteArticulation_MordentSemi from MuseScore in that case. It seems to be the same for Trills. MuseSamler needs a distinction between Semi and Halftone for any of those ornaments. The reason why this seems only not to work for oboe is because oboe has a dedicated/recorded articulation for while tone mordents. Whereas for example Violin uses the fallback notes sent over from MuseScore (which are correct)