musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

MusicTopMargin and MusicBottomMargin should not affect view boundaries in continuous view #20811

Open Lenbus opened 9 months ago

Lenbus commented 9 months ago

Issue type

UI bug (incorrect info or interface appearance)

Bug description

When I select Continuous View (btw. one of my favorite features <3) the upper bound of the page is most often cropped, so that text, chord symbols or rehearsal marks are not displayed within the white area of the (continuous) page and just seem to vanish in the background.

Steps to reproduce

Open a score with multiple staffs (like e.g. choir music) and switch to Continuous View.

Screenshots/Screen recordings

grafik

MuseScore Version

4.2

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

No response

MarcSabatella commented 9 months ago

That shouldn't happen - the view should include enough space to accommodate whatever the "music top margin" setting is (Format / Style / Page), and the default value should allow quite a bit of content above the top staff without causing problems. Looks like maybe your score has turned this value down. So for now, you should consider resetting that to the default, or even increasing further if necessary.

But that said, it certainly would be better if space were allocated automatically so you didn't have to worry about that setting.

If your score is at the default and still has this problem, please ZIP and attach it here. but the picture certainly looks like you've turned it down to next to nothing.

Lenbus commented 9 months ago

Thanks for your reply, @MarcSabatella. Oh, I guess you've found the cause: I have set the upper margin to 3 pt. Changing that back to e.g. 8 pt resolves the issue, but that is not, what I would consider to be a good bet, as Continuous view ist just for the working process and not to be presented in any way. Moreover upper margin of 2 or 3 pt is just, what best suits my need for tablet layout of my scores and looks absolutely fine in "Page View".

See examples below: Continuous View (cropped upper margin): P1: grafik P2: grafik

Page View (all looking fine): P1: grafik P2: grafik

Regards. :)

MarcSabatella commented 9 months ago

Indeed, fiddling with the music top margin is just the workaround. Ideally MuseScore would add more space as needed automatically in continuous view just as it already does in page view.

So bottom line, to me it's still a bug. A tricky one, though, since calculating the appropriate of extra space to leave above and beyond the music top margin requires analyzing the full score, and that's something we try to avoid doing very often since it slows things down. In MU3, the extra text would be pushed off the screen also at first, but you could then drag the canvas down to see more. In MU4, you can drag the canvas down, but the extra text spills onto the background where it's harder to see - or impossible if you've changed the background to black as you apparently have

Perhaps a quick fix could be, force the background to the same as the paper color when in continuous view. Not sure that distinction between paper and background serves any useful purpose in continuous view.

bkunda commented 2 months ago

See this video for what I think is the real issue here:

https://github.com/musescore/MuseScore/assets/86290556/255a26e8-6f2e-42a7-9a53-4f9b3d7fef00

I think it'd make most sense if the MusicTopMargin and MusicBottomMargin simply had no effect in continuous view.