musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.21k stars 2.65k forks source link

Make default drumset instrument more conventional #21402

Closed zacjansheski closed 8 months ago

zacjansheski commented 8 months ago

Your idea

The default drumset instrument is a hot mess.

A few "easy fixes" to consider:

  1. Omit the congas
  2. Shift Hi-hat open to the same space as the closed Hi-hat, there will be visual redundancy, but when the percussion UX/UI is changed in 4.4 this will not be an issue.
  3. Shift the splash cymbal up to -4, the smallest cymbal, highest pitch, set highest on the staff
  4. Omit Hi-Mid Tom, it is visual redundant with High Tom, there are still plenty of toms for most user's needs.

A few other considerations:

  1. Change Side Stick to "Rim knock" and change note head to "Slashed Forwards"
  2. Offer a minimal drum kit instrument that omits all but the essentials of a basic kit: Kick, snare, two mid toms, a floor tom, HH, 1 crash, 1 ride.

Problem to be solved

This is the current drumset

Screenshot 2024-02-07 at 12 01 43 PM

This is drumset with simple fixes

Screenshot 2024-02-07 at 12 03 02 PM

This is a minimal drumset

Screenshot 2024-02-07 at 12 21 20 PM

Prior art

Minimal Kit DRM

Minimal Drum Kit.drm.zip

Additional context

The drumset instrument is "hard coded" in MuseScore. It would be important to understand the potential problems of changing anything there.

Offering a "Minimal Drum Kit" could be done without making changes to the hard-coded drumset

zacjansheski commented 8 months ago

Really that top line should be used for a tom unless working with 5 toms

EvansSC1 commented 8 months ago

I would say that the current side-stick sound is more suited for a rim-click, and I would very much enjoy the actual adding of a rim-knock (cross-stick) sound at some point as well.

zacjansheski commented 8 months ago

@EvansSC1 agreed.

I need to understand the "hard coded" business better, the drum kit is glued to MIDI General drum mappings which uses the "Side-stick" term. So I would say that the fault is in the MS Basic soundfont.

I think if I have to prioritize this in a way, it should be Notation>Playback. The reason this matters is that we want to conform to standards of third party libraries.

In VDL, that C#2 is a "Cross Stick" not a rim. I believe most drumset libraries that are mapped to MIDI general follow that convention.

Additional functionality/sounds/playback features will be developed for Muse Sounds.

RobFog commented 8 months ago

I had read a while ago that there are plans to rework support for drum kit and percussion. I'm currently writing my master's thesis on drum notation support in scorewriters and I've spent some time analysing MuseScore.

The default drumset instrument is a hot mess.

Yes. I did find that many aspects of MuseScore's drum notation deviate from standard notation. I'd been wanting to reach out to you folks at MuseScores to see if my findings could be of any use. I didn't realise changes to MuseScore's default drum notation would be considered for version 4.3 already.

Omit Hi-Mid Tom, it is visual redundant with High Tom, there are still plenty of toms for most user's needs.

Like those two, "High Floor Tom" and "Low Floor Tom" are also placed in the same spot in the staff.

I would argue that in the non-minimal drum set users should be able to write six different toms as the percussion map of the General MIDI Specification stipulates.

Change Side Stick to "Rim knock" and change note head to "Slashed Forwards"

What do you mean by "Rim knock"? The MIDI key MuseScore refers to as "Side Stick" produces a sound we get from using what is commonly referred to as the "cross-stick" technique. The slashed notehead you propose is usually used to indicate a rimshot.

The drumset instrument is "hard coded" in MuseScore. It would be important to understand the potential problems of changing anything there.

I agree that changes to MuseScore's default drum input need to be very carefully considered.

Relevant thoughts and questions that come my mind:

I have a fear that things will get messier if changes are made now without knowing how the "much bigger changes planned for a later release" @shoogle mentioned in #development on Discord will look like.

I have started writing out my thoughts on how the drum input palette needs to be changed: https://github.com/orgs/musescore/discussions/21517

zacjansheski commented 8 months ago

@RobFog thanks for the input.

Cross-stick, rim-knock, and side-stick are used interchangeably. Cross-stick is the most clear so we should use that as the default term.

Weinberg is great, but also a little dated now. His rim-shot, ride bell, and rim-hit symbology have not really caught on in the common practice. I think the OrnateX is better suited for rim-shots.

My short-term solution is to offer a 4-piece and 5-piece drum kit as more simplified versions of the current kit. The current kit can be referred to as "Large Drum Kit" and the toms can be put on their proper lines. Musicxml imports should be opened with the "Large Drum Kit" by default.

RobFog commented 8 months ago

@RobFog thanks for the input.

Cross-stick, rim-knock, and side-stick are used interchangeably. Cross-stick is the most clear so we should use that as the default term.

Okay, thanks. I hadn't come across "rim knock" until now.

Weinberg is great, but also a little dated now. His rim-shot, ride bell, and rim-hit symbology have not really caught on in the common practice.

Are you sure?

I think the OrnateX is better suited for rim-shots.

I can't say I have ever seen an Ornate X notehead used for rim shots…?

My short-term solution is to offer a 4-piece and 5-piece drum kit as more simplified versions of the current kit. The current kit can be referred to as "Large Drum Kit" and the toms can be put on their proper lines. Musicxml imports should be opened with the "Large Drum Kit" by default.

You want to offer separate drum kits for people who want to notate either for two toms or for three toms?

zacjansheski commented 8 months ago

Weinberg's book was written over 25 years ago (published in 1998)

Percussion resists standardization, users can change noteheads if they like. We want to use the same symbols as VDL as our percussion defaults: Screenshot 2024-02-15 083414

Offering smaller kit instruments will be more non-percussionist friendly and third-party VST friendly

RobFog commented 8 months ago

Weinberg's book was written over 25 years ago (published in 1998)

Percussion resists standardization, users can change noteheads if they like.

I am well aware how old the book is. It is difficult to estimate a) how much more standardised drum notation has become thanks to the book and b) how standardised drum notation is in published works.

However, scorewriters Sibelius (Sibelius Reference Guide, Version 2023.11, p. 379) and Finale ("Percussion" in Finale's user manual ) both state they intend to follow Weinberg through their defaults. I reckon this contributes greatly to standardisation.

If MuseScore chooses to be the outlier, this hurts standardisation.

zacjansheski commented 8 months ago

The Sibelius guide references the book then proceeds to not follow it: Screenshot 2024-02-15 092716

RobFog commented 8 months ago

The drum key from Sibelius' Reference Guide lists "side stick" twice, once with an X note head and once with a slashed notehead, so either a) it's a typo and of them was supposed to say "rim shot" or b) they offer both options. But I don't see how it does "not follow" Weinberg?

I hadn't previously looked into Dorico but Inputting notes on a drum set states: "The default drum set in Dorico is already set up with the most common percussion playing technique noteheads, so the side stick snare drum note appears with a cross notehead."

So we have Sibelius, Finale and Dorico defaulting to Weinberg plus Drumeo and likely the PAS advocating for it. And on the other hand, we have VDL (who's responsible for that?) doing its thing…?

zacjansheski commented 8 months ago

But that's not what is in the Weinberg book. Weinberg uses the circled note for side-stick/cross-stick. If they (Dorico/Sibelius) mean a "rim", Weinberg uses a square articulation symbol for that. Weinberg didn't use x's for rims/rim-knocks because he didn't want to use the same noteheads as the cymbals. The square articulation symbol, I have never seen that "in the wild"

I have seen the circled note commonly, but it isn't great because it is visually very close to a ghost note.

Rims are used far less than cross-sticks, so they shouldn't be included in a minimal drum kit.

The slashed notehead is great for cross-stick and the ornate-x for shots. Very clear and easy to read.

Once again, users can change the noteheads to whatever they want.

RobFog commented 8 months ago

Thanks for engaging in the discussion, Zac.

But that's not what is in the Weinberg book. Weinberg uses the circled note for side-stick/cross-stick. If they (Dorico/Sibelius) mean a "rim", Weinberg uses a square articulation symbol for that.

You're right and I'm sorry. I did get things confused there.

The square articulation symbol, I have never seen that "in the wild"

I also haven't seen the square articulation symbol.

I have seen the circled note commonly, but it isn't great because it is visually very close to a ghost note.

Agreed.

Rims are used far less than cross-sticks, so they shouldn't be included in a minimal drum kit.

Okay. 👍

The slashed notehead is great for cross-stick and the ornate-x for shots. Very clear and easy to read.

Easy to read, yes. But not clear because slashed notepads are frequently used for rimshots:

Once again, users can change the noteheads to whatever they want.

I know. But lack of standardisation is a real pain in education. And "slashed notehead for cross-stick and the ornate-x for shots" appears to be an entirely new idea.

What's wrong with X notehead for cross-stick and slashed notehead for rimshots? That does seem to be a very common variation.

Weinberg didn't use x's for rims/rim-knocks because he didn't want to use the same noteheads as the cymbals.

Is that a reason you're against the X notehead?

zacjansheski commented 8 months ago

I think the VDL approach is strongest candidate for us to adopt for our defaults.

It is also my personal preference because the slash notehead looks like a stick laid over the drum, like a cross-stick, also the ornate-x "looks louder" than the slashed notehead. Of course my personal opinion is completely subjective. :)

Rather than pushing for standardization (which I would argue can be shackling), the inclusion of "legends" in every book/solo/piece should become the norm.

MarcSabatella commented 4 months ago

I did not see there further discussion of the first point in the original issue - the notation of open vs closed hi-hat. This has come up in support discussions and I definitely found this a surprising change to have been made for 4.3. Yes, of course, notating both open & closed on the same line/space makes sense if the appropriate articulation can be added automatically, but that’s not the case right now (4.3.2). So now we have users adding alternating open & closed hi-hat and not understanding why they look the same or what to do about it.

I guess it’s too late to do anything about this except start documenting it better and spreading the word. Unless there is any thought of a 4.3.3, in which case, I’d advocate for backing this particular change (the hi-hat) out. Or using a different notehead at least. And if a 4.3.3 happens, I’d also argue for naming the ”drum kit” instruments back to “drumset” because that’s what people are accused to typing into the search box or selecting from the list and pretty much daily we have people asking where the drumset went. This also feels to me like a change that would have been better reserved for 4.4.

zacjansheski commented 4 months ago

There is no accepted notation that puts the open HH on a different line or uses a different notehead. Using a different line/notehead makes it more difficult to use proper notation. I'd argue it actually encourages people to use improper notation.

"Drumset" is fraught. Sometimes one word, sometimes 2. The term is used for the percussion panel in "edit drumset" the nomenclature change is an objective improvement.

Searching for instruments should be improved at a higher level to be more forgiving. Many instruments have alternative names / spellings

MarcSabatella commented 4 months ago

I totally agree that long term the change makes sense in order to encourage proper notation. I’m just surprised to see it slipped into 4.3 with no warning to users, because now there is confusion that didn’t exist before. We’re going to have a lot of scores where people don’t add the articulations because they have no idea that is a thing and they just accept the articulation-less defaults, and then their scores will not differentiate open from closed at all. Which to me is worse than using the “wrong” line. That plus the cases where users notice the duplication and assume it’s a bug and report it as such. So I there is a very real cost to the change, even though it also comes with a benefit for users savvy enough to realize what has happened and they now need to do to get correct notation.

To me this would would have made more sense to wait on until 4.4, both because there will presumably be some more direct articulation support to help automate the correct notation, but also because we will be doing the sort of messaging that a change like this calls for.

Anyhow, as I said, it’s kind of moot now. We’ll just have to make sure we inform users that they will now have to manually add articulations to differentiate open from closed, whereas previously it wasn’t necessary because of the non-standard (but very well-established within the world of MuseScore) line assignments.

FWIW, the image above shows Sibelius supporting open hi hat with a different notehead as one alternative (first note of third line). So there is at least some precedent for it.