Color Notes plugin note working

nasehim7 commented 7 months ago

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

Colornotes plugin is not working on the score

Steps to reproduce

Open a score
Go to "Plugins" > Color Notes > Color Notes (assuming you have enabled it already from "Manage Plugins")
See that there won't be any change to the notes color in the score which is incorrect

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/18035782/fbcf8b2b-12e8-4fbd-bb4e-99c08224e0da

MuseScore Version

MuseScore version (64-bit): 4.4.0-, revision: github-musescore-musescore-

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

OS: macOS 13.6, Arch.: arm64

Additional context

In the logs, I can see that the undoStack() has 0 child count:

bkunda commented 7 months ago

@cbjeukendrup perhaps this plugin needs updating for the new version of Qt?

Jojo-Schmitz commented 7 months ago

I just tried, with the latest master build, on Windows 11: the ColorNotes plugin just works: Snippet from the logs:

2024-03-15T15:37:08.398 | DEBUG | main_thread     | expression for onRun | hello colornotes
2024-03-15T15:37:08.398 | INFO  | main_thread     | ActionsDispatcher::dispatch | try call action: notation-select-all
2024-03-15T15:37:08.426 | DEBUG | main_thread     | UiActionsRegister::updateEnabledAll | currentCtx: UiCtxNotationFocused
...
2024-03-15T15:37:08.746 | DEBUG | main_thread     | MeasureLayout::createEndBarLines | Clef Segment without Clef elements at tick 14/1
2024-03-15T15:37:08.752 | DEBUG | main_thread     | MeasureLayout::createEndBarLines | Clef Segment without Clef elements at tick 14/1
2024-03-15T15:37:08.912 | DEBUG | main_thread     | Score::endCmd   | Undo stack current macro child count: 470
2024-03-15T15:37:08.957 | DEBUG | main_thread     | UiActionsRegister::updateEnabledAll | currentCtx: UiCtxNotationFocused
2024-03-15T15:37:08.961 | DEBUG | main_thread     | UiActionsRegister::updateEnabledAll | currentCtx: UiCtxNotationFocused
2024-03-15T15:37:08.965 | INFO  | main_thread     | ActionsDispatcher::dispatch | try call action: notation-escape
2024-03-15T15:37:08.970 | DEBUG | main_thread     | UiActionsRegister::updateEnabledAll | currentCtx: UiCtxNotationFocused

So maybe it fails on macOS only?

cbjeukendrup commented 7 months ago

Works just fine for me too. @nasehim7 Is it broken for all scores, or perhaps just this one? In the latter case, could you upload it? And are you perhaps using a different version of the plugin than the builtin one?

nasehim7 commented 7 months ago

@cbjeukendrup it is happening for all the scores. So just now what I did, I pulled the latest master, build it. Here is the recording where I started from scratch with the step of enabling the plugin as well.

https://github.com/musescore/MuseScore/assets/18035782/02ec520d-53a8-48aa-bdd6-235e026621c5

This is the score in the video: https://www.dropbox.com/scl/fi/nvcfha3h91z35i71c7gni/Waltz_in_A_MinorChopin.mscz?rlkey=rekyhhv53chbbjtqjq9uwva33&dl=0

When I do it in 4.3, it works fine

Jojo-Schmitz commented 7 months ago

Again: works for me, also with that score (which stems from MuseScore 2.1)

wizofaus commented 5 months ago

FWIW, plugins that reference, e.g. QtQuick.Controls don't work for me in Development/master builds (but work fine in installed 4.3 version).

Jojo-Schmitz commented 5 months ago

Still Color Notes works for me, latest master (self-)build, but it apparently uses the one from extensions/colornotes rather than plugins/colornotes

musescore / MuseScore