search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.28k stars 2.66k forks source link

Dynamic text selection regression #22273

Open zacjansheski opened 7 months ago

zacjansheski commented 7 months ago

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

In 4.4 I am unable to click in highlighted dynamic text as I am in 4.3

Steps to reproduce

  1. In 4.4, add a dynamic to the score
  2. Double click the dynamic and add text
  3. Highlight
  4. Click within the highlighted text

The expected result is the behavior in 4.3, the highlight is gone and the text pointer is active at the point of clicking.

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/69917893/088fce59-f018-41e9-bdb4-8511bb78d6ea

MuseScore Version

OS: macOS 14.2, Arch.: x86_64, MuseScore version (64-bit): 4.4.0-240990302, revision: github-musescore-musescore-a715a7b

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Mac OS 14

cbjeukendrup commented 2 months ago

Not Qt-related. Seems caused by the addition of bool needStartEditingAfterSelecting() const override { return true; } in dynamic.h in 7383e3653e6eac330c676bec2b95dd0eb139dd8d.

RomanPudashkin commented 2 months ago

So basically this issue has the same cause as this one: https://github.com/musescore/MuseScore/issues/24172#issuecomment-2309761025

DmitryArefiev commented 2 weeks ago

Reopened. See https://github.com/musescore/MuseScore/pull/25215#issue-2597926659