search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.27k stars 2.66k forks source link

[Tech Debt] Use qml color picker #23244

Open Eism opened 4 months ago

Eism commented 4 months ago

Your idea

We are currently using a QColorDialog to allow the user to select a color, this is a QWidget class - this leads to all sorts of problems, for example https://github.com/musescore/MuseScore/issues/23208

We must use the qml version of this dialog. An example of such a transition is demonstrated for the folder selection dialog in this commit https://github.com/musescore/MuseScore/commit/7512c3b109022a967fad32381e11e6808dd9fc20

Problem to be solved

Another step towards abandoning QWidget in the project

Prior art

No response

Additional context

No response

MarcSabatella commented 4 months ago

Just a note to make sure opacity controls get included when this happens - they’ve been missing in MU4. See https://github.com/musescore/MuseScore/issues/13652