musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
11.79k stars 2.56k forks source link

correct globalSig #23351

Open sammik opened 6 days ago

sammik commented 6 days ago

if stretch = local / global

see f.ex.: https://github.com/musescore/MuseScore/blob/b5b34e22c7d55068a448bc12f0cdbbb9613d61d9/src/engraving/dom/edit.cpp#L1319 then global = local / stretch

-- alternatively, (and more loggicaly in my opinion) stretch should be global / local, then global would be local * stretch but it would require correcting all places in code, where it is used (one example is above)

Jojo-Schmitz commented 6 days ago

Same code in Mu3

Jojo-Schmitz commented 6 days ago

Mind to share the consequences of the bug you fixed?

sammik commented 5 days ago

Mind to share the consequences of the bug you fixed?

I dont know, if it even is used enywhere. I jus found it, when was working on something else, so I fixed it.