musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
11.79k stars 2.56k forks source link

Add keyboard shortcuts to control 'Voice assignment' property #23370

Open avvvvve opened 4 days ago

avvvvve commented 4 days ago

We currently have the following shortcut actions that can be used to move certain elements, like notes, from one voice to another when selected:

image

Now that dynamics and hairpins can be assigned to individual voices, these shortcuts should also work with those elements. Additionally, we can add actions to set the voice to either 'All voices on instrument' or 'All voices on this staff only'.

Tasks

Note: Waiting for sign-off to change the wording of 'Apply to voice' to 'Voice assignment'

avvvvve commented 4 days ago

@shoogle As far as I can tell these shortcuts not already taken by other actions, but just wanted to check with you that they make sense.

@bkunda Tagging for triage.

I know the wording of 'Use all voices...' is a bit awkward since it's really 'Assign to all voices...', but it's the only way for these to show up in the shortcuts list alphabetically next to the other voice assignment shortcuts. Alternatively, we could change the existing shortcuts to the form 'Assign to voice [#]'.

cbjeukendrup commented 3 days ago

Cmd+Opt+S should be reserved for "save all", which saves all open files. I believe that command doesn't exist yet in MuseScore, but it is standard to have it. And it might be wise to reserve Cmd+Opt+A for some selection functionality. I believe some apps do that, because of the similarity with Cmd+A. Cmd+Opt+A could be used for some kind of "Select similar".

avvvvve commented 3 days ago

Good point, and those would likely be used much more than these shortcuts.

Another couple options, based on their inclusion in number pads and their position next to each other on QWERTY keyboards:

OR

shoogle commented 3 days ago

How about Ctrl+Alt+0 for "Use all voices on instrument"?

We could use Ctrl+Alt+Shift+0 or Ctrl+Alt+- for "Use all voices on stave".

The advantage of Ctrl+Alt+- is it makes Ctrl+Alt+= the obvious choice for "Use all voices on system" if we add that again in the future.

avvvvve commented 3 days ago

I'd assume if we added the system option, we'd order them as such in the 'All' menu:

So then I'd keep the order of the shortcuts as such, as they're laid out left to right on the keyboard:

shoogle commented 3 days ago

The way I see it:

Ctrl+Alt+0 is the intuitive shortcut that users might try based purely on the "Use voice" shortcuts. We should use it for the default option that we want most people to use most of the time. We could debate whether instrument or staff should be the default, but nobody would argue that system should be the default.

avvvvve commented 3 days ago

I'm sold! I'll update the description with 0 and - as the shortcuts.