musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
11.93k stars 2.57k forks source link

UI for enabling plugins or assigning them to "extension points" is unclear and needs design #23421

Open cbjeukendrup opened 1 month ago

cbjeukendrup commented 1 month ago

Issue type

UI bug (incorrect info or interface appearance)

Bug description

In the panel to manage a plugin's shortcut and enabledness, there is now a dropdown to enable a plugin or assign it to an "extension point".

This will need a UI design pass. The main problems with it are the following:

Also, I'm personally still of the opinion that this is not the right way to present these "extension points" to the user. Instead, I'd prefer to see it as a sort of "if this than that" style automation, where you see a list of possible triggers and then assign plugins or other actions to these triggers. Now, it feels like it's the wrong way around, where you have to assign a trigger to a plugin.

Steps to reproduce

  1. Open Home > Plugins
  2. Click a plugin to see the panel appear

Screenshots/Screen recordings

Scherm­afbeelding 2024-07-01 om 16 56 13

MuseScore Version

master (4.4)

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

*

Additional context

No response

TeeDeeY commented 4 weeks ago

A related issue is that setting title: “title” conditionally in version 4.4 in the “onCompleted” section no longer works. The Jan 4 version has the changes described here and title in the menu doesn’t work, conditionally. Late June 4.4 does work.

Since I don’t know the design goals, it’s difficult to comment. But, using conditional logic allows one plug-in to load in versions 3.6, 4.2 and 4.4, assuming other components are also compatible.

If this should be reported and documented separately, please tell me. It could be that titles go away by design, making posting pointless.

cbjeukendrup commented 4 weeks ago

That is more related to https://github.com/musescore/MuseScore/issues/23419, but I think it would be good to open a new issue for that. The idea is not to remove the concept of plugin titles, but the old API will be deprecated at some point. However, for 4.4 there shouldn't really be any changes. The reason that you're still seeing some regressions in the latest nightly builds, is that development of the new API has already started. We'll try our best to minimise the amount of regressions before the final 4.4 release. (An official announcement about the developments around the plugins API will follow soon.)