play toolbar broken, tempo not clickable or selectable with keyboard

2-www commented 2 months ago

Issue type

Accessibility issue (e.g. for keyboard-only or screen reader users)

Description with steps to reproduce

create a new file in musescore
try to change tempo in the toolbar

time is drawn over buttons, clicking the tempo selects the time, tab skips over it

Supporting files, videos and screenshots

screenshot

What is the latest version of MuseScore Studio where this issue is present?

4.3.2

Regression

I was unable to check

Operating system

Debian

Additional context

default ui scaling (100%), reproducible with both ukrainian and english language set, and with all settings reset to defaults, and with layout reset to default

Checklist

[X] This report follows the guidelines for reporting bugs and issues
[X] I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
[X] I have attached all requested files and information to this report
[X] I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

cbjeukendrup commented 2 months ago

This issue shows some visual similarity to https://github.com/musescore/MuseScore/issues/21036, but that one doesn't mention the fact that tab skips over it. The conclusion of that issue though is that it is specific to the FlatPak build, over which we don't have control. Reportedly, this bug does not occur in the "official" AppImage from musescore.org, and that might have to do with the fact that the AppImage used a different Qt 5 version than the FlatPak.

I'm interested how this will be after we release version 4.4, because that uses Qt 6.

MarcSabatella commented 2 months ago

I think there is some confusion here. That display is read-only - it's not a way to set the tempo. Setting the tempo is done by adding tempo marking to the score itself.

However, if you undock the play panel, it does expose a control that provides a temporary override to the actual tempo. And that control is inaccessible as far as I know, because I don't think there is a keyboard-only way to undock the toolbar.

While we could add a keyboard command to undock a focused toolbar, I don;t think this is really the best solution. Really. that temporary tempo override shouldn't require undocking - that's a super commjin complaint about MU4. The problem arose only because there was an oversight in the original toolbar layout, where it wasn't realized the MU3 had an override. So the undock hack was kind of tacked on to provide a quick workaround. But it's high time we solve this for real, by making that override directly available within the toolbar.

bkunda commented 2 months ago

@2-www could you please add some further reproduction steps to this? It's not exactly clear from the report how you are trying to change the tempo.

Also a screen recording would be very helpful.

2-www commented 2 months ago

However, if you undock the play panel, it does expose a control that provides a temporary override to the actual tempo. And that control is inaccessible as far as I know, because I don't think there is a keyboard-only way to undock the toolbar.

can you make it show the ovveride slider in a popover when the tempo display is clicked?

2-www commented 2 months ago

@2-www could you please add some further reproduction steps to this? It's not exactly clear from the report how you are trying to change the tempo.

i can add it from the palette if i didn't add the mark in the creating dialog. marc explained the problem here

2-www commented 2 months ago

This issue shows some visual similarity to https://github.com/musescore/MuseScore/issues/21036

yes it looks the same

The conclusion of that issue though is that it is specific to the FlatPak build

no, people say it's on the fedora package too, and it becomes normal in flatpak if you uninstall the gnome theme

cbjeukendrup commented 2 months ago

Okay, so to summarise, there are two things here:

The time digits appear offset, but that part is a duplicate of https://github.com/musescore/MuseScore/issues/21036 and according to that issue it only occurs in third-party created builds and not in our AppImage, so we don't really have control over that
You would like to access the tempo slider via a popup triggered by the tempo display. I think that's a very reasonable request, and in fact I almost implemented that but never fully finished it. When I have a moment, I'll pick that up again and create a PR for it.

musescore / MuseScore