musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.28k stars 2.66k forks source link

Sound flags carry over between instrument changes. #23746

Open SOSnake opened 3 months ago

SOSnake commented 3 months ago

Issue type

General playback bug

Description with steps to reproduce

  1. Add an instrument with a sound flag in your score.
  2. Activate a specific sound flag.
  3. Add "Change instr." from the Text tab and change the instrument to something else after you've set the sound flag. Make sure the other instrument does not support the same sound flag.
  4. Add some notes to the instrument you just added.
  5. Start playback and notice the lack of sound from the new instrument.

If you then add a sound flag to that new instrument it works again.

Supporting files, videos and screenshots

https://github.com/user-attachments/assets/3b181c7b-46d7-459b-ba1f-7c8dc5a097c6

What is the latest version of MuseScore Studio where this issue is present?

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.2-241630831, revision: github-musescore-musescore-22b46f2

Regression

No.

Operating system

Win 11

Additional context

The issue is probably just MuseScore not removing sound flags after an instrument change if the new instrument does not support that sound flag.

In the recording I have added the piano in the background, because I am not allowed to send just clear samples or smt due to the license... yippie

Checklist

bkunda commented 3 months ago

@zacjansheski this one might need further investigation.

avvvvve commented 3 months ago

First thought is we might need to do something like this: When adding an instrument change that comes after a sound flag, a sound flag set to the default sound for the new instrument should automatically be added at the same location as the instrument change.