musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.26k stars 2.65k forks source link

Electric Guitar (treble clef) incorrectly transposes when linking to a TAB staff #23873

Open mkj42 opened 3 months ago

mkj42 commented 3 months ago

Issue type

Engraving bug (incorrect score rendering)

Description with steps to reproduce

With the instruments Acoustic Guitar (treble clef) and Guitar (treble clef) if you link a TAB staff, it behaves correctly as expected.

If, however, you try to link a TAB staff to Electic Guitar (treble clef), the TAB is incorrect (transposed one octave too high).

electric guitar tab error

Supporting files, videos and screenshots

electric guitar tab error.zip

What is the latest version of MuseScore Studio where this issue is present?

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.2-241630831, revision: github-musescore-musescore-22b46f2

Regression

No.

Operating system

Windows 10 64 home

Additional context

This should be solvable with simple modifications to the instruments.xml file.

Checklist

Jojo-Schmitz commented 3 months ago

I haven't checked yet, but I doubt it to be a Mu3 regression

mkj42 commented 3 months ago

I corrected the regression status already, but the regression tag still stands. I didn't issue the tag; I don't know how to remove it.

cbjeukendrup commented 3 months ago

No worries, I removed the label (only team members can do that). As a workaround, I guess that editing the transposition in the Staff/Part properties dialog might work (which is probably what the instruments.xml fix will essentially be).

mkj42 commented 3 months ago

I've done it for my personal 3.7 Evo. The corrected file is on the issue there: https://github.com/Jojo-Schmitz/MuseScore/issues/552

mkj42 commented 3 months ago

Update: I successfully modified the electric guitar (treble clef) section in the instruments.xml file, using the other two treble clef guitars for comparison.

I updated the string data (+12 on each of the six entries)
I verified correct clef, transposing clef, diatonic and chromatic transpose entries (all were correct)

This issue can indeed be easily fixed by changing the included instruments.xml. instruments.zip

electric guitar tab error fixed

cbjeukendrup commented 3 months ago

For MS4, I think @shoogle will need to make those updates in his Instruments spreadsheet. For easier editing, the current instruments.xml file is namely automatically generated based on a spreadsheet.

Jojo-Schmitz commented 2 months ago

Also missing are the channels

                  <Channel name="open">
                        <!--MIDI: Bank 0, Prog 27; MS General: Clean Guitar-->
                        <program value="27"/> <!--Electric Guitar (clean)-->
                  </Channel>
                  <Channel name="mute">
                        <!--MIDI: Bank 0, Prog 28; MS General: Palm Muted Guitar-->
                        <program value="28"/> <!--Electric Guitar (muted)-->
                  </Channel>
                  <Channel name="jazz">
                        <!--MIDI: Bank 0, Prog 26; MS General: Jazz Guitar-->
                        <program value="26"/> <!--Electric Guitar (jazz)-->
                  </Channel>
                  <Channel name="harmonics">
                        <!--MIDI: Bank 0, Prog 31; MS General: Guitar Harmonics-->
                        <program value="31"/> <!--Guitar Harmonics-->
                  </Channel>
                  <Channel name="distortion">
                        <!--MIDI: Bank 0, Prog 30; MS General: Distortion Guitar-->
                        <program value="30"/> <!--Distortion Guitar-->
                  </Channel>
                  <Channel name="overdriven">
                        <!--MIDI: Bank 0, Prog 29; MS General: Overdrive Guitar-->
                        <program value="29"/> <!--Overdriven Guitar-->
                  </Channel>