musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.64k forks source link

Midi Lyric export (4.4.0 preview) does not take repeats into account resulting in missing lyric text #24168

Closed japj closed 2 months ago

japj commented 2 months ago

Issue type

Import/export issue

Description with steps to reproduce

  1. install a 4.4.0 preview that includes the Midi Lyric export feature (after August 14th 2024)
  2. make a score containing notes with lyrics and a simple repeat, including notes and text after the repeat
  3. export as midi
  4. import this midi again

Results: where repeated text would be, the text from after the repeat is shown, the last notes do not have any text at all

Expected: repeated text to be correct in midi export

Supporting files, videos and screenshots

Initial score, to be exported as midi Repeat with lyrics

Result score, imported from midi Repeat with lyrics-1

Repeat with lyrics.mscz.zip

What is the latest version of MuseScore Studio where this issue is present?

OS: macOS 14.6, Arch.: arm64, MuseScore Studio version (64-bit): 4.4.0-242271422, revision: github-musescore-musescore-a4ac62c

Regression

I was unable to check

Operating system

macOS 14.6

Additional context

No response

Checklist

cbjeukendrup commented 2 months ago

@bakajikara Would you have a chance to look into this? Otherwise no worries, then someone else can do it :)

bakajikara commented 2 months ago

Sure! I've created a PR for it. See #24171