Concert Toms doesn't always use the same drumset

wizofaus commented 1 week ago

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

Create a new score, any instrument, single staff is plenty
Add a change instrument and pick "Concert Toms"
Right-click on the staff after this and choose "edit drumset". The drumset shows Mid Tom Rim/Mid Tom etc. with only A B C shortcuts
Now add another change instrument after this, and again pick "Concert Toms"
Right-click on the staff after this and choose "edit drumset"
Actual: drumset shows Tom 1...6 with 6 shortcut keys defined.
Expected: both steps 3 & 5 should reveal the same drumset, presumably the latter one.

Supporting files, videos and screenshots

What is the latest version of MuseScore Studio where this issue is present?

4.4

Regression

I was unable to check

Operating system

Windows 11

Additional context

Doesn't happen if MuseSamplerCoreLib.dll isn't loaded and everything is MS Basic - only the Tom 1....Tom 6 drumset is shown in that case. Meaning I can't debug it at all, because the moment that library is loaded by the debugger everything dies.

Checklist

[X] This report follows the guidelines for reporting bugs and issues
[X] I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
[X] I have attached all requested files and information to this report
[X] I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

MarcSabatella commented 6 days ago

I cannot reproduce this. I tried a variety of different starting instruments and couldn't get it to fail when adding the instrument change. Please attach your specific score - save it after step one. Might be best to also attach a version after step 2 in case something unique about your configuration is causing the issue; that would allow us to look inside the score to get a clue if we still can't reproduce ourselves with the first version of the score.

wizofaus commented 5 days ago

From what you were saying you always saw the Tom 1...6 drumset, but that's the MS Basic one, and actually doesn't work properly for Muse Sounds (the sounds are wrong - I don't think Muse Sounds even has 6 different tom pitches).

MarcSabatella commented 5 days ago

I'm not sure what it means to say "that's the MS Basic one", but to be clear: it's the one added by default when actually adding Concert Toms as your instrument with Muse Sounds installed and configured as your default profile. Not just when using instrument changes, and not just when using MS Basic. It's the only Concert Toms definition I see. But it's true that it doesn't produce meaningful playback with Muse Sounds, but does with MS Basic. So in that sense at leas,t I guess you could consider it "the MS Basic one".

wizofaus commented 5 days ago

There is a separate drumset for Muse Sounds Toms with only 3 pitches (and the "Rim" variants), which is the one I see after adding a second change instrument, I believe that's the "correct" one (even though it's quite limited pitch-wise).

MarcSabatella commented 4 days ago

That may be, and if so, the bug to me would appoear to be that there is no way to actually cause that drumset to be selected. Because nothing that I try will result in that happening. Maybe that's Linux only, because the Muse Sampler isn't updated? But again, if you would attach the two versions of your score as I requested, I could try again to reproduce the problem with that score. Niught be that is has tioo do with some other customizations you've done.

musescore / MuseScore