musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.29k stars 2.66k forks source link

Add "Same color" checkbox to the two Select More dialogs #24827

Open krasko78 opened 1 month ago

krasko78 commented 1 month ago

Your idea

I'd like to add a "Same color" checkbox to the two "Select More" dialogs (when a note is selected and when some other type of element is selected). I use this feature regularly and believe it could be useful to others as well.

Problem to be solved

I like to color certain elements in my scores for different reasons. Having the ability to select "Same color" on the "Select More" dialogs provides added control over what to select, allowing for selecting all the elements colored in a certain color.

Prior art

No response

Additional context

No response

Checklist

bkunda commented 1 month ago

It sounds like this could be generalised to all properties associated with the selected object (E.g. "select all objects with this property").

Good idea! Thanks for suggesting it.

krasko78 commented 1 month ago

@bkunda @cbjeukendrup Can someone assign it to me please? Thanks.

krasko78 commented 1 month ago

Here's what I have so far: image

Notes and questions:

  1. I moved "In selection" at the bottom with a separator as I don't think it fits well within the "Same XXX" checkboxes.
  2. I moved "Same system" and "Same measure" one row up because moving "In selection" freed that row. One concern I have here is that the users might be well used to the placement of the checkboxes already and not welcome this rearrangement.
  3. I added the "Same color" checkbox to the right of "Same beat".
  4. Note that "Same duration" is in different locations on both dialogs. Do we want to change this to make them more similar?
  5. Notice the vertical placement of "Replace selection": on the first dialog it is at the top whereas on the second one it is in the middle (spanning two rows). Do we want it positioned in the same way and, if yes, which alignment do you prefer?
  6. On the "Select dialog" (the one on the right), to the right of "Element" and "Same subtype" there are two QLabels with focusPolicy set to "StrongFocus" and both have tab stops. What is the point of this?

Let me know what you think and if there is something you want me to change/revert. Many thanks!