musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

Allow for asynchronous inspector updates #24863

Open bluebear94 opened 1 week ago

bluebear94 commented 1 week ago

Resolves: #14383

Previously, updating the inspector model would cause QML components to be created synchronously, causing a delay when selecting certain elements. We set an incubation controller on the QQmlEngine to allow for objects to be created asynchronously when requested. To avoid blocking the main thread when updating the inspector, we also replace the StyledFlickable + Repeater combo with a StyledListView.

Current bugs: the space above the separator lines is missing

cbjeukendrup commented 1 week ago

This looks good to me now! Are you planning to make further changes in this PR, or is it time to mark it 'ready for review' so that I can approve it?

bluebear94 commented 4 days ago

I don’t have any further changes planned.

RomanPudashkin commented 4 days ago

@bluebear94 please rebase your PR to fix the red vtests, thanks!