musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

fix(time signatures): adding a time signature does not deselect current measure(s) #24891

Open brobrobrob opened 1 week ago

brobrobrob commented 1 week ago

Resolves: #9584

Jojo-Schmitz commented 1 week ago

Isn't this a duplicate of #24892 (or vice versa)?

brobrobrob commented 1 week ago

Isn't this a duplicate of #24892 (or vice versa)?

Yes, this is the correct one because it merges into master

brobrobrob commented 1 week ago

This is a draft btw, you don't have to review now! I thought the convention was to mark as 'ready for review' when I am ready for review @Jojo-Schmitz

Jojo-Schmitz commented 5 days ago

Those merge commits should not be there, please try a git pull --rebase upstream master followed by a git push -f

brobrobrob commented 5 days ago

Those merge commits should not be there, please try a git pull --rebase upstream master followed by a git push -f

Done