musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

Lyrics odd/even lines not sticking after changing them in properties, clicking away and saving #24896

Open MRoth1910 opened 1 week ago

MRoth1910 commented 1 week ago

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

  1. Add music that has lyrics odd and even lines.
  2. Go to change them (sometimes MS will incorrectly assign the odd and even lines).
  3. Click away and save.
  4. Go back to properties, see that they have reverted.

I discovered that MS Studio had swapped text around (where lyrics odds lines were behaving as evens and vice-versa) in a score which I made with some version of MS 4 at the end of Dec 2023. I copied that into a new score and had a problem where, in replacing the text by moving from syllable by syllable with the keyboard, moving from m. 3 to would take me to the wrong line…This persisted after upgrading to 4.4.0 (where I discovered the issue) to 4.4.2.

A temporary fix is achieved by removing the lyrics with "Delete" but that's not ideal.

Issue is at mm. 3 and 4 in attached score file included as a .zip file.

Supporting files, videos and screenshots

https://github.com/user-attachments/assets/d6f71b80-c654-4373-b502-ab860ccfff55

psaumes_vêpres_rosaire.mscz.zip

What is the latest version of MuseScore Studio where this issue is present?

4.4.2

Regression

I was unable to check

Operating system

macOS 15.0 Sequoia

Additional context

Stems from issue here. I'd have reported it earlier, but I didn't notice it back in Dec and only now clued into the problem of changing the odd/even line as "not taking".

Checklist

bkunda commented 1 week ago

@zacjansheski pls regression check

zacjansheski commented 1 week ago

I am having some trouble following along with the reproduction steps of this issue. Perhaps I am missing something obvious, but I haven't been able to reproduce an issue from scratch using 4.3.2 scores or with your attached score.

In step 2: "Go to change them (sometimes MS will incorrectly assign the odd and even lines)." What change are you making specifically? What is the desired result of the change? Are there changes that always reproduce the issue?

When I follow along with your video,

  1. Select mm4, verse 2 (Properties - text style reads: Lyrics even lines)
  2. Select verse 3 (Properties - text style (incorrectly) reads: Lyrics even lines)
  3. Change to Lyrics odd lines

I am seeing different results when I open the attached score in 4.4.2

  1. Select mm4, verse 2 (Properties - text style reads: Lyrics even lines)
  2. Select verse 3 (Properties - text style (Correctly) reads: Lyrics odd lines)

https://github.com/user-attachments/assets/6548aeaf-9ccc-4979-b152-85483b0ad47a

MRoth1910 commented 1 week ago

I don't know what to say, really other than I spent a solid half hour messing around with Properties and changing the verse from Odd to Even only for it to not stick. I'd click Odd (when it was Even) or vice-versa, move on to the next verse, only for it to not save.

in other words, the top text of the bulk of the verses should be EVEN but and the second line ODD (because it's indeed v. 2 and v. 3, having moved the first line above) but MS wasn't registering this, and then after changing this in properties and clicking away, I'd have to do it again until I just removed the lyrics and started over.

MRoth1910 commented 1 week ago

Screen Recording 2024-09-24 at 12.32.29.zip I think that this should be a better explanation (I hope…). The change made in properties does not hold. Instead of reentering all of the mostly-indentical music in a new score, I replace the lyrics which works without a problem (or only with other problems due to variable lengths of the text, as you can't simply move down existing lines to add new lines of text above). But if the lines are odd on one side and even on the other (and vice-versa) the cursor jumps around requiring manual intervention. And then that complicates adjusting the lyrics' position on the page.

MRoth1910 commented 1 week ago

Psaumes_aux_vêpres_Circoncision.mscz.zip and I'm on 4.4.2 with this one as well. Only solution on my end is to completely remove existing lyrics and start over. Which is, surprisingly, not as easy for me as replacing existing text!

zacjansheski commented 1 week ago

Thank you! I understand now, I will clean up this report a bit

  1. In 4.3 Override odd/even text style for lyrics in properties
  2. Save and confirm setting is maintained
  3. Open score in 4.4, Custom assignment is lost, text style is reset/reassigned to default ODD/EVEN
  4. Try to change/override, assignent will maintain default ODD/EVEN

https://github.com/user-attachments/assets/ffab6b86-1c5b-47c6-a04b-13064359a88f

zacjansheski commented 1 week ago

For testing/reproducing

4.3.2 Lyric Test.mscz.zip