musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.65k forks source link

String "Show graphics info ..." not in Transifex #24942

Closed Magnus26 closed 3 weeks ago

Magnus26 commented 3 weeks ago

Issue type

UI bug (incorrect info or interface appearance)

Description with steps to reproduce

  1. Open Edit -> Preferences.
  2. Click on Shortcuts and in the list to the right look up "Show graphics info..."
  3. That string is not in Transifex and thus can't get a translation.

Supporting files, videos and screenshots

Screenshot_20240927_100211

What is the latest version of MuseScore Studio where this issue is present?

4.4.2

Regression

I was unable to check

Operating system

Q4OS

Additional context

No response

Checklist

Jojo-Schmitz commented 3 weeks ago

I can't find that string anywhere in the MuseScore code. Hmm, I do, sort of, but as Show g&raphics info… https://github.com/musescore/MuseScore/blob/968f4e4bb39787a434a0c32c57bf5ac6b66ef5f4/src/framework/diagnostics/internal/diagnosticsactions.cpp#L52

It probably crept in after 4.4.0 got released and as such hasn't yet been pushed to Transifex, but will for 4.5?

Magnus26 commented 3 weeks ago

I can't find that string anywhare in the MuseScore code. Hmm, I do, soft of, but Show g&raphics info…

Do you see "Show graphics info..." in MuseScore Studio's user interface like in the image I attached?

Jojo-Schmitz commented 3 weeks ago

Yes. And in Diagnose > System too

Magnus26 commented 3 weeks ago

OK; there I have the r underlined.

cbjeukendrup commented 3 weeks ago

I've pushed it to Transifex, after updating the source strings file without -no-obsolete, to preserve compatibility with 4.4.0 and 4.4.1. If you translate the string now, not only 4.4.3 but also 4.4.2 will benefit from it.

Magnus26 commented 3 weeks ago

I've pushed it to Transifex, after updating the source strings file without -no-obsolete, to preserve compatibility with 4.4.0 and 4.4.1. If you translate the string now, not only 4.4.3 but also 4.4.2 will benefit from it.

What about "Show graphics info..." without the & before r?

Jojo-Schmitz commented 3 weeks ago

The occurrence in the shortcut list uses the same string and translation, it just ignores the &

Magnus26 commented 3 weeks ago

That ignoring has not worked on some other strings.

Jojo-Schmitz commented 3 weeks ago

It does here

cbjeukendrup commented 3 weeks ago

When it doesn't, it's usually a translation error, where translators added a & where they shouldn't have. Will need to be corrected on a case-by-case basis on Transifex.