search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

fix: gp5 voltas import #24981

Open mikekirin opened 1 day ago

mikekirin commented 1 day ago

Measure with the end repeat barline must have a Play count value that is equal to, the total number of times of playback of this measure + 1 or more https://musescore.org/en/handbook/4/voltas#change-playback

Jojo-Schmitz commented 1 day ago

That + 1 is present in importgtp.cpp and importgtp-gp4.cpp too

It doesn't make sense though, and the failing unit test seems to prove it. There there repeat cound would need to be much higher, 8, as there are that many voltas (ignoring the missing of a volta for the 4th, 5th and 7th round)

a 2 is actually enough there, but that last measure neeeds a play count of at least 4 and an end repeat barline.

Jojo-Schmitz commented 1 day ago

play count needs to be one more that the 1st volta's repeat list length... here (in that unit test) a 2, the default, is perfectly correct