cannot use shortcut (show-corrupted-measures)

jamestomk commented 3 hours ago

Issue type

UI bug (incorrect info or interface appearance)

Description with steps to reproduce

see Musescore help discussion https://musescore.org/en/comment/1261028 according to Jojo-Schmitz https://musescore.org/en/user/4901, this operation is commented out except for Debug build, and therefore the operation "show-corrupted-measures" should not appear in the production build Shortcuts list.

edit Preferences
choose Shortcuts
search for "show-corrupted-measures"
click on "Define"
set up an unused keystroke like "Ctl-,"
click on OK, notice that the short cut is accepted, click on OK to close
attempt to use the shortcut either by selecting a staff, measure, or select All and use the keystroke
notice nothing happens

Supporting files, videos and screenshots

cap

What is the latest version of MuseScore Studio where this issue is present?

MuseScore Studio 4.4.2 64-bit | Windows

Regression

Choose option...

Operating system

Windows 11

Additional context

No response

Checklist

[X] This report follows the guidelines for reporting bugs and issues
[X] I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
[X] I have attached all requested files and information to this report
[X] I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

Jojo-Schmitz commented 3 hours ago

And this seems to be a regression vs. Mu3

Hold on, if you enable dev mode, that "show-corrupted-measures" should work, like when you have this in your MuseScore4.ini (Windows, but there's also a mechanism for this for Mac and Linux)

[application]
devModeEnabled=true

In which case you won't really need the shortcut, unless you want to switch the "Show corrupted measures" off, as it is on by default, instead of just using the corresponding menu entry under Diagnose > Engraving Edit: nah, that's only the default for debug builds, as far as I can tell.

That shortcut should better be named "Toggle 'Show corrupted measures'")

I don't know whether there's a documented official way of enabling this dev mode

cbjeukendrup commented 2 hours ago

No, dev mode won't help here, MStaff::corrupted is surrounded with #ifndef NDEBUG

Jojo-Schmitz commented 2 hours ago

OK, then the shortcut and the menu entry should get the same treatment as that MStaff::corrupted or, better, vice versa, as this is a really usefull option

cbjeukendrup commented 2 hours ago

Yes, afaics, the overhead introduced by this option is very minimal, so we can provide it for non-debug builds too

musescore / MuseScore