musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.23k stars 2.65k forks source link

Unchecking a staff in Measure Properties is not fully Undoable #25104

Open rpatters1 opened 2 weeks ago

rpatters1 commented 2 weeks ago

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

  1. Create a new file with at least two staves or (alternatively) open the attached file.
  2. Right-click a measure and then open Measure properties.
  3. Uncheck the first staff.
  4. Ok out and then Undo.

The measure remains hidden and this cannot be Undone. However, internally the code seems to think it is not hidden. You can see this by

  1. Reopen Measure properties. The Staff is showing checked even though the screen is showing it hidden.

I have marked it "UX/Interaction" but there potentially could be "File corruption."

Supporting files, videos and screenshots

meas-test.mscz.zip

What is the latest version of MuseScore Studio where this issue is present?

Latest dev version

Regression

No.

Operating system

macOS 12.7.6

Additional context

No response

Checklist

zacjansheski commented 2 weeks ago

There isn't a clear or reproducible risk of file corruption, after undoing and making an edit to the score it is visually refreshed and the measure is visible again. Also after saving and reopening the measure is also visible again.

https://github.com/user-attachments/assets/1675c90f-56ea-4ab2-968b-3b817bf8f50c