musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.23k stars 2.65k forks source link

Breve rests on single line staves should hang down. #25246

Open rpatters1 opened 1 week ago

rpatters1 commented 1 week ago

Issue type

Engraving bug (incorrect score rendering)

Description with steps to reproduce

  1. Open a new file with (e.g.) bass drum as an instrument.
  2. Set the time to 4/2 or larger.
  3. See that the breve rests are above the line.

Supporting files, videos and screenshots

Gould "Behind Bars" is very clear that breve rests should hang below a single staff line. See p. 38:

Screen Shot 2024-10-20 at 9 51 12 AM

What is the latest version of MuseScore Studio where this issue is present?

4.4.2

Regression

I was unable to check

Operating system

macOS 12.7.6

Checklist

rpatters1 commented 5 days ago

I created a trial solution for this that resolves not only this issue but also the issue that full-measure breve rests don't avoid other voices. I am putting it here in case someone wants to look at it. I think a better solution is to implement #25279.

https://github.com/rpatters1/MuseScore/tree/trial-fullmeasure-rest-fix

XiaoMigros commented 5 days ago

Despite the issue you linked it's still better to change the default, no?

rpatters1 commented 5 days ago

Despite the issue you linked it's still better to change the default, no?

I think it is better to change the default, but #25279 would allow some cleverness around importing existing files and maintaining their current positioning. It is true that there may be very few existing scores that use full-measure breve rests on single-line staves. But what we decide around that is above my pay grade. Personally I tend to be OCD about porting everything without changes.

XiaoMigros commented 5 days ago

Personally I tend to be OCD about porting everything without changes.

That's what Finale does to oneself...

On a serious note I don't think this change would cause unexpected results in 99.9% of scores, and if it does it's a very simple matter of selecting the rests and pressing Ctrl+R

rpatters1 commented 5 days ago

I should add, if my trial branch makes sense to be a PR, I will open one on it. It doesn't get in the way of a fancier implementation later.

XiaoMigros commented 5 days ago

I think that would make sense, at a glance the code looks good and that's the most reliable way of getting staff feedback (and if they don't like it they'll tell you to close it!)