Style dialog too big by default; OK/Cancel buttons fall of the screen on smaller screens

SvendAndersen commented 1 week ago

Task

Decrease the default height of the style dialog to 760px.

This will ensure that it's not cut off on a standard small laptop with 1366×768px resolution.

Also, if a user manually resizes the dialog, MuseScore Studio currently recalls its last dimensions even if you quit and restart. So when changing the default, ideally we would not reset the size of the dialog for users who have already manually resized it.

Edit above by @avvvvve, original issue text below

Issue type

Other type of issue

Description with steps to reproduce

In the new version of Musescore 4 there is an error under Layout, as the Ok button is missing. This means that the choices you have made are not saved and Layout therefore in practice does not exist. Today I completed the latest update, where the error was not fixed. I hope the error will be corrected. Kind regard Svend Andersen Denmark

Supporting files, videos and screenshots

What is the latest version of MuseScore Studio where this issue is present?

Version 4

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

No response

Checklist

[X] This report follows the guidelines for reporting bugs and issues
[X] I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
[X] I have attached all requested files and information to this report
[X] I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

MarcSabatella commented 1 week ago

The button is present; your screen resolution just isn't high enough to be showing it. Resize the dialog to be smaller and it will be visible.

The dialog is entirely too big by default, though. It should be able to fit comfortably on any system using common display resolutions, but it really doesn't. There are a couple of existing issues that indirectly touch on this - see #21907 and #24917 - but really, if a full refactor is only a long term goal, we should find a way to make this dialog fit onto more displays, as we get complaints about this quite often in the forums etc.

Jojo-Schmitz commented 1 week ago

And it isn't really a Mu3 regression, there too users occasionally complained about this.

Also the dialog can be masde smaller by the users by grepping the top line of the windows and dragging it down, then grabing the title bar and dragging it up, so you can see the buttons at the bottom.

avvvvve commented 1 week ago

Added the specification to solve this issue to the top of the description (make the default height 760px), so this is ready for a contributor to take on!

SvendAndersen commented 1 week ago

I have now found a temporary solution to the problem by changing the display setting. On my monitor it was set to the recommended 125%. I changed it to 100% and the problem was solved. Svend Andersen Denmark

avvvvve commented 17 hours ago

@SvendAndersen Glad you figured out a fix. I think we should still go ahead and change the default height as I outlined above so that users with small screens don't run into this issue.

musescore / MuseScore