Fix - Crash due to large custom Time Signature

[Abhay-Varnekar]

Resolves: #12970

Summary of Changes:

• Numerator Field Limit: Added a maximum value of 999 to the numerator field (zNominal) to restrict user input.
• Graphics Rendering Optimization: Modified the graphics rendering behavior to avoid continuous re-renders while typing. The graphics now only re-render when the user presses Enter or moves focus away from the numerator field.

• [x] I signed the CLA
• [x] The title of the PR describes the problem it addresses
• [x] Each commit's message describes its purpose and effects, and references the issue it resolves
• [x] If changes are extensive, there is a sequence of easily reviewable commits
• [x] The code in the PR follows the coding rules
• [x] There are no unnecessary changes
• [x] The code compiles and runs on my machine, preferably after each commit individually
• [ ] I created a unit test or vtest to verify the changes I made (if applicable)

[Jojo-Schmitz]

use git pull --rebase upstream master; git push -f and squash your 2 commits into one, after having fixes the trailing spaces

[Jojo-Schmitz]

That editstyle.ui change should not be in this PR

[Abhay-Varnekar]

That editstyle.ui change should not be in this PR

Yess removed it

[Jojo-Schmitz]

Strange, I now don't see where that codestyle check failure comes from

[Abhay-Varnekar]

Strange, I now don't see where that codestyle check failure comes from

Yess I too am not able to figure out the issue here as I used the code from the main repo and made mine changes keeping in mind the trailing spaces

[cbjeukendrup]

This is the problem:

diff --git a/src/palette/view/widgets/timedialog.cpp b/src/palette/view/widgets/timedialog.cpp
index 342d3b7..1458987 100644
--- a/src/palette/view/widgets/timedialog.cpp
+++ b/src/palette/view/widgets/timedialog.cpp
@@ -154,7 +154,7 @@ void TimeDialog::zChanged()
     int denominator = this->denominator();

     Fraction sig(numerator, denominator);
-    
+
     // Update beam groups view
     groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text());
 }

On blank lines, no indentation should be applied.

[Jojo-Schmitz]

I don't see that one on GitHub though

[Abhay-Varnekar]

This is the problem:

diff --git a/src/palette/view/widgets/timedialog.cpp b/src/palette/view/widgets/timedialog.cpp
index 342d3b7..1458987 100644
--- a/src/palette/view/widgets/timedialog.cpp
+++ b/src/palette/view/widgets/timedialog.cpp
@@ -154,7 +154,7 @@ void TimeDialog::zChanged()
     int denominator = this->denominator();

     Fraction sig(numerator, denominator);
-    
+
     // Update beam groups view
     groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text());
 }

On blank lines, no indentation should be applied.

Thanks a lot for pointing it out. I will make sure to note this and not make such mistakes hereafter.

[zacjansheski]

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved https://github.com/musescore/MuseScore/issues/12970 FIXED