musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.65k forks source link

MuseScore 3.5 Release Candidate. PRs to be merged #6195

Closed anatoly-os closed 4 years ago

anatoly-os commented 4 years ago
RobFog commented 4 years ago

4757?

shoogle commented 4 years ago
ecstrema commented 4 years ago
Spire42 commented 4 years ago

Fixes bugs and regressions introduced in #5623, #5922, and #6186.

Jojo-Schmitz commented 4 years ago

Issues without PRs (yet):

(Issues with) PRs:

worldwideweary commented 4 years ago
tobik commented 4 years ago
MarcSabatella commented 4 years ago

Still not totally clear on the criteria for what is being considered, but to me these are good candidates. They are not regressions (well, not new regressions in 3.5 anyhow) but they do address some real pain points that are easily solved. And they don't involve new strings or otherwise require new documentation, they just allow things to work that people have every right to expect to work anyhow.

MarcSabatella commented 4 years ago

The following issue needs to be resolved:

https://musescore.org/en/node/307005.

The following PR addresses it directly:

And then also

Another possible approach is #6259 which disables chord symbol playback for pre-3.5 scores, but I think the consensus is #6268 is preferable.

tobik commented 4 years ago
jeetee commented 4 years ago
AntonioBL commented 4 years ago
shoogle commented 4 years ago
lvinken commented 4 years ago
Spire42 commented 4 years ago

By popular demand. Undoes the change to the default zoom type that was made in #5623.

worldwideweary commented 4 years ago
rettinghaus commented 4 years ago
lvinken commented 4 years ago
MarcSabatella commented 4 years ago

I edited a comment above to list #6268 (changes default playback sound for chord symbols to piano) as the consensus on how to handle compatibility/surprise concerns for older scores with chord symbol playback.

Jojo-Schmitz commented 4 years ago

Yet unresolved issues (without PRs, as those don't make sense there):

MarcSabatella commented 4 years ago
CodeforEvolution commented 4 years ago

This would really help to have this added to the 3.5 release, as it would make it easier for the folks over at HaikuPorts (Haiku’s main package management repo).

MarcSabatella commented 4 years ago
Jojo-Schmitz commented 4 years ago
Harmoniker1 commented 4 years ago

This PR also fixes an issue of the stem length becoming a bit longer than necessary for chords with tremolo strokes and a downward stem. It also makes one-note tremolo layout slightly better.

Jojo-Schmitz commented 4 years ago

I'd like to see this PR in 3.5RC, even if not being a 3.5 regression, but it finally seems to make continuous mode with lyrics usable again:

MarcSabatella commented 4 years ago

No PR yet, but this is a serious regression that needs to be fixed:

MarcSabatella commented 4 years ago

I believe this is important for 3.5, otherwise people will employ workarounds that will break when this does get fixed:

Jojo-Schmitz commented 4 years ago

No PR yet, but this is a serious regression that needs to be fixed:

anatoly-os commented 4 years ago

Congratulations with 3.5 Release Candidate! https://musescore.org/en/3.5rc