musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.64k forks source link

[MU4 Issue] MU4 shows ampersands in menu #9311

Closed njvdberg closed 2 years ago

njvdberg commented 3 years ago

Describe the bug Menu items contain an ampersand in the text instead of underlying the shortcut character.

To Reproduce Steps to reproduce the behavior:

  1. Open MU4

Expected behavior Instead of &File I expected to see File

Screenshots image

Desktop (please complete the following information):

Additional context Normal behavior (on KDE/Plasma) is that the character preceded by the ampersand is underlined when the Alt key is pressed. However is MU4 always underlines there characters is fine too.

exegetor commented 2 years ago

This also happens under Windows 10 x86_64, with the current commit (a1979d7).

martin-danhier commented 2 years ago

It seems that the translator is not working properly, thus Qt uses the key of the string instead which is not supposed to be seen directly.

After looking more into it, I couldn't get any translation working:

image

It would seem that all of those issues are related.

(While I'm referencing issues, I will also reference #8090 since this issue is one of the listed tasks)

I imagine that the translation files on the MuseScore website are obsolete because of MuseScore 4 changes. Are these translations accessible somewhere, or are they closed source like the website ?

cbjeukendrup commented 2 years ago

There are (almost) no translations done for MuseScore 4 yet. Because many strings and their translation contexts changed, the translators will have a big amount of work to do. I believe the plan is that they can start translating when the alpha is released.

The translation process is mostly a community effort, and takes place on Transifex: https://www.transifex.com/musescore/musescore/

Your reasoning about the ampersands is not completely correct; those ampersands are namely also written in the translated strings. What's going on is that we are using a custom menu bar component, and we haven't yet written the code to replace the ampersand with an underline for the next character and add a shortcut.

Jojo-Schmitz commented 2 years ago

Also reported in https://musescore.org/en/node/327250

wizofaus commented 2 years ago

Note that while the & no longer appear, the underscores that do appear when you press ALT (on Windows) seem too close to the text: image

Also other than the top level menus, the only commands that seem to show accelerators are ones that open out submenus ("File|Open Recent", "View|Toolbars", "View|Workspaces" etc. etc.).

Perhaps best done as a separate bug? @Tantacrul @njvdberg

Eism commented 2 years ago

@wizofaus

Perhaps best done as a separate bug?

Yes, you are right. Thanks Need to open an issue on porting ampersands from MU3. @DmitryArefiev for you

DmitryArefiev commented 2 years ago

Note that while the & no longer appear, the underscores that do appear when you press ALT (on Windows) seem too close to the text: image

Also other than the top level menus, the only commands that seem to show accelerators are ones that open out submenus ("File|Open Recent", "View|Toolbars", "View|Workspaces" etc. etc.).

Perhaps best done as a separate bug? @Tantacrul @njvdberg

@wizofaus @Eism I've logged #12467 for the 1st issue. The 2nd bug doesn't occur on my side (Win/Lin)