museumsvictoria / nodel-recipes

Recipes used by Nodel hosts.
MIT License
14 stars 12 forks source link

Front-end: Some URL-encoded characters cause display failure #28

Closed justparking closed 1 month ago

justparking commented 6 years ago

To replicate, set up a Front-end node, for example: SW-BPAM02 (XMV8280-D Rack 1)

1: http://localhost:8085/nodes/SW-BPAM02%20(XMV8280-D%20Rack%201)/index-sample.xml works correctly: image

2: http://localhost:8085/nodes/SW-BPAM02%20%28XMV8280-D%20Rack%201%29/index-sample.xml does NOT (blank page): image

In this example, it's the () being encoded as %28%29 respectively, however this may highlight some kind of general escaping issue.

This is an issue because many of the Nodel browsers redirect the user to the encoded version (2).

scroix commented 1 month ago

This was addressed a while back. I can't recall exactly which PR, but the extraneous names in "( )" etc are ignored in the URLs now.

e.g. SW-BPAM02 (XMV8280-D Rack 1) would appear as (http://localhost:8085/nodes/SWBPAM02/index.xml)