museumsvictoria / nodel-recipes

Recipes used by Nodel hosts.
MIT License
13 stars 12 forks source link

Application Controller *new* Windows "app-node" #53

Closed scroix closed 4 years ago

scroix commented 4 years ago

Off the back of our last adventure I thought I'd get around to adding the elusive "app node" into the public repository.

It's (what I believe is) the latest version which has been floating around.

I've done a couple of things.

├───Application Controller   <--- the new location
│   └───Windows
├───Brightsign
├───Calendar
├───Computer Controller
│   ├───General
│   └───Windows 10

The Process() function does work on Linux. I don't believe I've ever had it working on macOS. However due to the inclusion of the CPUChecker.cs and reliance on the ProcessSandbox.exe I've decided to describe this as a Windows-specific recipe.

Although, I'm wondering whether we should remove the CPUChecker.cs in favour of using the Computer Controller?

justparking commented 4 years ago

Regarding naming, I thought it was cleaner to use the short and simple term "App" as that's how the code refers to itself too. And "Launcher" instead of "Controller" because I reckon the latter overstates what it does.

I also moved it to root level (Windows) and wrote a note about macOS support (or lack thereof).

Hope that works for you!

scroix commented 4 years ago

I'm 100% happy with your changes!

Thank you 😄