search

museumsvictoria / nodel

A digital media control system for museums and galleries
nodel.io
60 stars 17 forks source link

Remote event error feedback should be suppressed during node recycle #288

Open justparking opened 1 year ago

justparking commented 1 year ago

This occurred during a node restart:

Remote event handling failed - java.lang.IllegalStateException: Event handling failure (internal server error) - 'remote_event_IPAddress'-

Remote event handler error feedback could be suppressed if the toolkit is being shutdown or already shutdown.

justparking commented 6 months ago

The same applies to active HTTP calls - they can fail silently too.

Or anything that's done via the toolkit.

And if not entirely suppressed, dumping an entire stack trace can be avoided.

justparking commented 5 months ago

The same should apply to action, emit and call handlers, e.g. after a recycle this might happen where the error is simply because the node it restarting.

05-24 09:23:38.36 (action) Traceback (most recent call last):
05-24 09:23:38.37   File "/opt/nodel/./nodes/Frontend/ingredient_echo.py", line 7, in EchoRequest
05-24 09:23:38.37     local_event_EchoReply.emit(arg)
05-24 09:23:38.37 AttributeError: 'dict' object has no attribute 'emit'