search

museumsvictoria / nodel

A digital media control system for museums and galleries
nodel.io
60 stars 17 forks source link

Misc UI bug fixes #335

Closed mcartmel closed 3 months ago

justparking commented 4 months ago

Hey @scroix and @thefennecdeer - do you mind doing a quick review of the changes in case you spot something that might cause an issue?

My only concern is this part:

// proactively disconnect websocket when the page is not being viewed

If it means it readily disconnects and reconnects the websocket, it might have a noticable effect flipping between browser tabs (and in particular, those hosting large dashboards/frontend). I know that the websocket code syncs up the state of all events every time it connects.

I've put this to @mcartmel already.

scroix commented 4 months ago

I'll take a look and report back 🫡

scroix commented 3 months ago

No immediate issues with the dashboard updating across multiple devices/browsers, but I don't have the scale that @thefennecdeer would be dealing with.

@justparking, I did have a bit of trouble running the binary on Java 8. I can't recall whether we were enforcing Java 11 now. It might've just been my IDE settings overriding our Gradle rules for compatible builds.