museun / cargo-whatfeatures

a simple cargo plugin to get a list of features for a specific crate
Apache License 2.0
73 stars 1 forks source link

Request for comments regarding removal of JSON output #34

Closed museun closed 4 years ago

museun commented 4 years ago

I'm thinking about removing the json support to make the output visitor simpler.

If anyone relies on this, I would like to know before I rip it out.

Currently there are a few formatting bugs/quirks that are difficult to fix because of how the 'output' state is produced/perserved. Because json needs to be well formed, I have this weird begin/middle/end finite automata that makes calculating total width/height/columns a bit tedious.

I also want to move to cargo-metadata to be in line with other cargo tools, it has a rigid model for how/when json should be rendered. If I do decide to keep the json output, its format will change. I'll try to come up with something like json-schema (or json5 or even ndjson) to have a well-formed output.

museun commented 4 years ago

Removing json output support