musevlt / mpdaf

MUSE Python Data Analysis Framework
BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

mpdaf fsfmodel check #24

Closed nfbouche closed 7 months ago

nfbouche commented 2 years ago

For the version (3.6dev), the documentation says

OldMoffatModel (model='MOFFAT1'): the old model with a fixed beta [DEPRECATED].

MoffatModel2 (model=2): a circular MOFFAT with polynomials for beta and FWHM.

shouldn't the sdetect.py/add_PSF method have { if (fsfmodel.model != "ModelMoffat2") and (fsfmodel.model != 2): raise ValueError('This method is coded only for FSFMODE=2') } instead of { if (fsfmodel.model != "MOFFAT1") and (fsfmodel.model != 2): raise ValueError('This method is coded only for FSFMODE=2') }

nfbouche commented 7 months ago

no longer applicable