Closed pjlantz closed 11 years ago
Looks good so far. If you agree regarding "TCP/UDP should be configurable", I'll accept and you can follow up with whatever we agree upon :)
I agree, is it ok to add a connection_type
field to the settings file?
Shouldn't it be connection_protocol_type to be correct?
What about keeping a layer_ prefix like network_protocol_type
? Also, I'd like to configure host, port and protocol in the same place. Do you think it's best using gevent_client.Client.__init__()
or Layer1.settings()
?
I'd do it in the Client as it is more related to it.
Do you have anything left to do for this issue?
IMO the issue could be closed. Thanks for your help.
Done thanks to Andrea
Here's a pull request for a draft implementation: https://github.com/buttinsky/buttinsky/pull/24 I don't know if that's what you meant, please let me know if there's more work/refactoring to be done.