coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 1087
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 20 unchanged lines in 4 files lost coverage.
- Overall coverage increased (+0.07%) to 71.262%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| conpot/protocols/ipmi/ipmi_server.py | 2 | 69.1% | ||
| conpot/protocols/http/command_responder.py | 4 | 58.02% | ||
| conpot/protocols/ftp/ftp_handler.py | 7 | 80.84% | ||
| conpot/protocols/ftp/ftp_base_handler.py | 7 | 77.64% | ||
| <!-- | Total: | 20 | --> |
| Totals | |
|---|---|
| Change from base Build 1086: | 0.07% |
| Covered Lines: | 5371 |
| Relevant Lines: | 7537 |
creolis
I'm a hpfeeds user. I would be a much happier conpot user if it was closer to the json output.
This PR is a step towards this - it breaks out src ip/port and dst ip/port into seperate fields. It leaves the other fields there for now as I don't want to break other hpfeeds users.
A specific example where the current schema is annoying in ES. If i feed the conpot event stream via hpfeeds as is it will choke ES - it does not like mixed type tuples (these fields are str/int).