mushorg / conpot

ICS/SCADA honeypot
GNU General Public License v2.0
1.21k stars 410 forks source link

Decouple Databus from SessionManager #490

Closed srenfo closed 4 years ago

srenfo commented 4 years ago

This moves the Databus object out of the SessionManager. This allows future tests to instantiate SessionManagers without bothering with the databus.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1186


Files with Coverage Reduction New Missed Lines %
conpot/protocols/http/web_server.py 3 85.71%
conpot/protocols/enip/enip_server.py 7 63.87%
conpot/protocols/ftp/ftp_handler.py 9 82.93%
conpot/protocols/ftp/ftp_base_handler.py 13 80.12%
conpot/protocols/http/command_responder.py 61 54.73%
<!-- Total: 93 -->
Totals Coverage Status
Change from base Build 1181: -0.4%
Covered Lines: 5505
Relevant Lines: 7577

💛 - Coveralls
srenfo commented 4 years ago

Let me know if this change is too small or too non-consequential. I can bunch up such changes instead.