mushorg / conpot

ICS/SCADA honeypot
GNU General Public License v2.0
1.23k stars 415 forks source link

Refactor bin/kamstrup_prober #517

Closed BusinessFawn closed 3 years ago

BusinessFawn commented 3 years ago

Refactored for readability and added new def layout to reduce complexity

fixes issue #500

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1223


Files with Coverage Reduction New Missed Lines %
conpot/protocols/ftp/ftp_server.py 1 96.18%
conpot/protocols/ftp/ftp_base_handler.py 3 86.85%
conpot/protocols/http/web_server.py 3 85.71%
conpot/protocols/ftp/ftp_handler.py 11 81.75%
conpot/protocols/http/command_responder.py 35 54.23%
<!-- Total: 53 -->
Totals Coverage Status
Change from base Build 1222: -0.3%
Covered Lines: 5495
Relevant Lines: 7495

💛 - Coveralls
BusinessFawn commented 3 years ago

I'm a little confused how the coverage went down on files I didn't touch? Anyone have any ideas?

glaslos commented 3 years ago

hm, they might just compare to the previous run and if it changes how they measure coverage you end up seeing loss/win on unaffected lines. But definitely confusing...

BusinessFawn commented 3 years ago

Made the updates. I used either .info or .exception for logging. Didn't know if we needed more granularity there.