search

mushorg / conpot

ICS/SCADA honeypot
GNU General Public License v2.0
1.21k stars 410 forks source link

Dockerfile should build current code #521

Closed srenfo closed 3 years ago

srenfo commented 3 years ago

Despite a very misleading comment, the Dockerfile will always build the public master rather than the code in the current working copy:

https://github.com/mushorg/conpot/blob/ff09e009d10d953aa7dcff2c06b7c890e6ffd4b7/docker/Dockerfile#L6-L9

If Docker is the recommended way to run Conpot then it should be possible to do so during development.

srenfo commented 3 years ago

After an (admittedly quick) attempt at fixing this I'm not sure anyone actually uses the Dockerfile in production. It appears broken for the current code even beyond #519.

If the Docker approach is abandoned I suggest it is deleted rather than fixing this issue. If it is not I highly suggest it is incorporated into the CI pipeline (cf. #486).

Though again, I only had a quick go at this, so the error may well be on my end.

glaslos commented 3 years ago

No, I can confirm the Dockerfile is borked. I'm working on a new one. I'll create a draft PR tomorrow. I'm a bit stuck or just need a 2nd pair of eyes...

glaslos commented 3 years ago

See here: https://github.com/mushorg/conpot/pull/522