Fixing the Dockerfile - Githubissues

mushorg / conpot

ICS/SCADA honeypot

GNU General Public License v2.0

1.21k stars 410 forks source link

Fixing the Dockerfile #522

Closed glaslos closed 3 years ago

glaslos commented 3 years ago

The container builds but there are issues when running it. Would appreciate someone to have a look at it as well. Justification for dropping Alpine as base container: https://pythonspeed.com/articles/alpine-docker-python/

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1279

0 of 0 changed or added relevant lines in 0 files are covered.
15 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 73.619%

Files with Coverage Reduction	New Missed Lines	%
conpot/protocols/ftp/ftp_handler.py	5	82.46%
conpot/protocols/ftp/ftp_base_handler.py	10	80.92%
<!--	Total:	15	-->

Totals
Change from base Build 1275:	0.2%
Covered Lines:	5545
Relevant Lines:	7532

💛 - Coveralls

srenfo commented 3 years ago

FYI there is #491 for the failing coveralls checks.

glaslos commented 3 years ago

Yeah, annoying that I have to add a test somewhere just to make coveralls happy... Maybe we should give another tool a try 🤔

srenfo commented 3 years ago

Yeah, annoying that I have to add a test somewhere just to make coveralls happy... Maybe we should give another tool a try thinking

I think it's a false positive. I don't see your changes in this PR impacting the coverage.

I suspect it's comparing the wrong things... maybe coverage across runs from different branches?

glaslos commented 3 years ago

@srenfo good to merge?

srenfo commented 3 years ago

@srenfo good to merge?

It just now successfully built and ran on my machine. :1st_place_medal:

I don't have a merge button, so please go ahead. :smile: