Refactor bin/conpot - Githubissues

mushorg / conpot

ICS/SCADA honeypot

GNU General Public License v2.0

1.21k stars 409 forks source link

Open glaslos opened 3 years ago

glaslos commented 3 years ago

Would be nice if it can be a file conpot.py with Python extension. setup.py needs to be updated to make this possible.
The file should only do flags, startup message and initializing/running Conpot.
Everything template should be in a separate module.
Everything starting protocols should be in a separate module.
Everything logging should be in separate module.
Everything moved into a separate module should have test coverage.

NishantPuri99 commented 3 years ago

Hi, Can I try this out?

glaslos commented 3 years ago

Of course, no need to ask :)

srenfo commented 3 years ago

Ideally there would also be tests where possible. Don't know if you want to add this to the requirements.

I realize that testing main() is notoriously difficult, but with a split in separate modules (or at least functions) this should be much easier.

glaslos commented 2 years ago

@NishantPuri99 have you had any success?