search

mushorg / conpot

ICS/SCADA honeypot
GNU General Public License v2.0
1.21k stars 409 forks source link

Fix IPMI tests in an IPv6 world #545

Closed srenfo closed 3 years ago

srenfo commented 3 years ago

This /should/ fix the test failures in #529, in three-ish steps:

  1. Expose the error message by redirecting stderr to stdout, i. e. failed asserts now show stderr rather than an empty string.
  2. Do not hardcode localhost. Ask the test server for its host instead.
  3. Convert the process output to unicode. I assume this was a remnant from Python 2. (Not actually a bugfix.)

My assumption is that this doesn't change anything on Travis but should fix the GH Actions once they're rebased.