search

mushorg / glastopf

Web Application Honeypot
http://glastopf.org
550 stars 170 forks source link

fix missing attribute "version" on AttackEvent #249

Closed vicvega closed 9 years ago

vicvega commented 9 years ago

AttackEvent does not have an attribute "version" Without this PR current syslog support just doesn't work

glaslos commented 9 years ago

@nsmfoo can you have a look at this?

nsmfoo commented 9 years ago

@glaslos yes sure. It seems like the my all the code changes I had in my pull request did not get committed(?), see https://github.com/glastopf/glastopf/compare/master...nsmfoo:master

I probably did something. Given my code syslog should have version information ..

glaslos commented 9 years ago

It might be that I missed some commits when cherry picking. I'll have a look tonight.

nsmfoo commented 9 years ago

Next time it will look less messy I promise =)

katkad commented 9 years ago

yes, it looks like this one is missing https://github.com/nsmfoo/glastopf/commit/8d5e469e2ffcf8664686b0767e7ea42ad5fa0a1e

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 5b51716 on vicvega:fix_syslog into 01a0484 on glastopf:master.

glaslos commented 9 years ago

fixed with 8d5e469