mushorg / tanner

He who flays the hide
GNU General Public License v3.0
222 stars 103 forks source link

Scope for padding Oracle Vulnerability #298

Closed amanjiofficial closed 5 years ago

amanjiofficial commented 5 years ago

Corresponding changes in 'tanner.utils.patterns.py' is to be made and 'tanner.emulators.pad_oracle.py' is to be changed accordingly.

afeena commented 5 years ago

@amanjiofficial before we can proceed with your pr, please complete the functionality :)

amanjiofficial commented 5 years ago

@afeena pls check that is this the right way to implement this functionality?

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 841


Changes Missing Coverage Covered Lines Changed/Added Lines %
tanner/emulators/pad_oracle.py 9 13 69.23%
<!-- Total: 14 18 77.78% -->
Totals Coverage Status
Change from base Build 822: 0.6%
Covered Lines: 931
Relevant Lines: 1654

💛 - Coveralls
afeena commented 5 years ago

@amanjiofficial you can use some tools to check your regular expression https://www.owasp.org/index.php/Testing_for_Padding_Oracle_(OTG-CRYPST-002)

amanjiofficial commented 5 years ago

@afeena I guess the commit is okay to be merged. Please suggest if I should make any changes.

afeena commented 5 years ago

@amanjiofficial please, if you want to get more guidance, explain you idea and code in more details :)

glaslos commented 5 years ago

Closing this due to inactivity and unresolved issues. Feel free to open a new PR with changes made according to the conversation here.