search

mushorg / tanner

He who flays the hide
GNU General Public License v3.0
222 stars 104 forks source link

optional postgress database #322 #370

Closed steve7158 closed 4 years ago

steve7158 commented 4 years ago

@glaslos @afeena please check this PR if it is relevant to issue #322

glaslos commented 4 years ago

Please adhere to PEP8 and I'd recommend to not use an ORM. Also I'd like to see more than just a database connection 😉

steve7158 commented 4 years ago

Ok ill update you as soon as possible:+1:.

afeena commented 4 years ago

@steve7158 please use async for your implementation :)

steve7158 commented 4 years ago

Ok, @afeena ill do that :smiley: .

steve7158 commented 4 years ago

@afeena, @glaslos its far from complete let me know if i am moving in a right track or not. :smile:

steve7158 commented 4 years ago

also please let me know if it is a good practice or not to make PR commits that are incomplete. I thought it of as a way to review my code. Thank you

glaslos commented 4 years ago

It's fine and recommended if you work on a project for the first time. Now you already got important feedback that helps you preparing a solid PR

steve7158 commented 4 years ago

I see thank you @glaslos