mushorg / tanner

He who flays the hide
GNU General Public License v3.0
220 stars 101 forks source link

make analysis of session a separate background task #395

Closed mzfr closed 4 years ago

mzfr commented 4 years ago

This PR will separate the analysis and deletion of the session.

afeena commented 4 years ago

don't forget to cancel the task in cleanup_background_tasks

afeena commented 4 years ago

@mzfr could you please fix the tests?

mzfr commented 4 years ago

@afeena Yes I am working on them, Trying to understnad why they are failing.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1381


Changes Missing Coverage Covered Lines Changed/Added Lines %
tanner/server.py 7 19 36.84%
tanner/sessions/session_analyzer.py 44 63 69.84%
<!-- Total: 51 82 62.2% -->
Files with Coverage Reduction New Missed Lines %
tanner/sessions/session_manager.py 1 73.42%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 1377: -0.4%
Covered Lines: 1566
Relevant Lines: 2014

💛 - Coveralls