search

mushorg / tanner

He who flays the hide
GNU General Public License v3.0
220 stars 101 forks source link

Remove loop parameter, fixes #422 #427

Closed t3chn0m4g3 closed 6 months ago

t3chn0m4g3 commented 1 year ago

This fixes #422, however it also requires Python 3.10 to begin with.

mzfr commented 1 year ago

@t3chn0m4g3 Would this break if someone was using a Python version lower than 3.10? Also, have you made sure that this change doesn't break the functionality of the Queue and SessionAnalyzer?

And just something for me, can you please link up the asyncio docs which says that the new version has removed the usage of the loop parameter?

t3chn0m4g3 commented 1 year ago

@mzfr Yes, only 3.10 will be supported then. During 24h in production I did not see any issues, which is no guarantee, though 🙈

mzfr commented 1 year ago

@t3chn0m4g3 Yes that is the thing right now everything we have was tested properly with python 3.7 so now merging a change that works only with 3.10 might not be a good idea until everything is tested with 3.10.

Would you be willing to give an update about how things are going in your PROD in about a week? If all things stays stable then maybe we can go ahead and merge this PR

t3chn0m4g3 commented 1 year ago

@mzfr Sure, will do.

t3chn0m4g3 commented 6 months ago

Meanwhile fixed with 2803c2773b8797d2632c6e36c6e5ea716b95c3b1 by @glaslos