mushroomhostage / exphc

The Experimental Hardcore Post-Apocalyptic Minecraft Server
www.exphc.com
8 stars 5 forks source link

Iron Chests: crystal chest lag, @ Post render 1282: Invalid operation log spam #60

Closed mushroomhostage closed 12 years ago

mushroomhostage commented 12 years ago

With the 1.2.5rev4 mods, near certain blocks, receive this repeated log spam:

########## GL ERROR ##########
@ Post render
1282: Invalid operation

and subsequent low frames/second (client lag)

mushroomhostage commented 12 years ago

Occurs in 1.2.5rev4, not earlier. Maybe related to Secret Rooms Mod blocks? Was placing ghost block and one-way glass.

edit: nope, still occurs at same location without Secret Rooms Mod. There are horses from Mo' Creatures nearby however. Spawned horse, no lag. Also placed JFM clock blocks, no lag either. Something else.

mushroomhostage commented 12 years ago

This lag can get unbearable, get about 10 fps, when normally get around 100. There was a helicopter nearby, destroyed it, no change. Not related to Optifine, MAtmos, Rei Minimap, EnchantView, InvTweaks.. nor Aquaculture, Mo' Creatures, Elemental Creepers.. not even Trees++, Thx, or Smart Moving and Player API.

mushroomhostage commented 12 years ago

It's Iron Chests! Specifically, their Crystal Chests. Place an item into it, will cause the errors:

########## GL ERROR ##########
@ Post render
1282: Invalid operation
mushroomhostage commented 12 years ago

Reproduced with MCPC #172 + mod_ironchests-server-3.6.1.34-bukkit-mcpc-1.2.5.zip on server, and minecraftforge-client-3.3.8.152.zip, mod_ironchests-client-3.6.1.34.zip, no other mods. As soon as you put an item into the Crystal Chest, causes invalid operation errors.

edit: and on single player, too.

mushroomhostage commented 12 years ago

Reported upstream http://www.minecraftforum.net/topic/981855-125-forge-sspsmpbukkit-ironchests-36-upgrade-vanilla-chests/page__st__320__gopid__16324743#entry16324743

mushroomhostage commented 12 years ago

Corroborated at http://www.minecraftforum.net/topic/981855-125-forge-sspsmpbukkit-ironchests-36-upgrade-vanilla-chests/page__st__320#entry16330198 - and confirmed does not occur with 3.3.1.

Changes to rendering - last on June 25th, 2012: https://github.com/GenuineSounds/ironchest/commits/a3e2e6bb7104cc100c3b435d700e651484143502/IronChests2/client/cpw/mods/ironchest/client/TileEntityIronChestRenderer.java

Sure enough, if I replace the cpw/mods/ironchest/client/TileEntityIronChestRenderer.class in mod_ironchests-client-3.6.1.34.zip with the older version from mod_ironchests-client-3.3.1.21.zip, the problem no longer occurs. Calling this mod_ironchests-client-3.6.1.34+renderfix.zip until fixed upstream.

mushroomhostage commented 12 years ago

Could it be: http://lists.apple.com/archives/Mac-opengl/2003/Aug/msg00024.html "Well, it turns out that one OS X 3D driver throws an error 1282 (invalid operation) if you ask it to draw 0 quads, but none of the others do"

mushroomhostage commented 12 years ago

Reported to GenuineSounds on #minecraftforge

 <GenuineSounds> exphc, I might as well just fix that and maybe add more optimizations.
mushroomhostage commented 12 years ago

3.7 has the log spam fixes, no longer get <10 fps lag, but get about 20 fps, still much worse than https://github.com/downloads/mushroomhostage/ironchest/mod_ironchests-client-3.6.1.34+renderfix.zip (which has 3.3.1's rendering). Will just use 3.6.1.34+renderfix.zip for now.