search

music-assistant / companion

Music Assistant Companion App
https://music-assistant.io/companion-app/
Apache License 2.0
39 stars 5 forks source link

User configurable ouput device #20

Closed arctixdev closed 8 months ago

arctixdev commented 8 months ago

Fixes #19

PatrikTheDev commented 6 months ago

This PR breaks the aarch64 macOS build and causes the app to crash on macOS Sonoma 14.4 on M1 Pro and potentially other devices on other versions.

image

Version 0.0.26 and older work correctly, 0.0.27 and newer (versions with this PR merged) crash on launch

PatrikTheDev commented 6 months ago

More specifically, this call to the Squeezelite binary causes issues

https://github.com/music-assistant/companion/blob/e9784ecfc05383a4b277da819be1172a68f6c2b9/src-tauri/src/main.rs#L36C5-L40C56

chmod 755 /Applications/Music\ Assistant\ Companion.app/Contents/MacOS/squeezelite fixes this, it appears as if the squeezelite binary isn't marked as an executable

gbcatrinoiu commented 6 months ago

on my machine the app got installed as music-assistant-companion so the command would be chmod 755 /Applications/music-assistant-companion.app/Contents/MacOS/squeezelite