search

music-assistant / companion

Music Assistant Companion App
https://music-assistant.io/companion-app/
Apache License 2.0
39 stars 5 forks source link

Mac build fix #24

Closed JeffersonBledsoe closed 4 months ago

JeffersonBledsoe commented 7 months ago

Seems the executables didn't have exec permissions, causing the squeezelite client loading code to throw when trying to get the possible audio output devices. There was also some shenanigans on macOS where using a path other than bin for externals was causing it to sometimes fail.

Hopefully fixes #23

JeffersonBledsoe commented 7 months ago

@arctixdev Can you test this on linux? I have 0 rust knowledge and cobbled through this. But I can get my dev build of the app to start now after this PR.

cc @Smarthome-creator incase you're able to get a dev build going and want to test this prior to a release

arctixdev commented 7 months ago

Hmm dosnt seem to work on linux let me quickly investigate further

JeffersonBledsoe commented 7 months ago

Hmm dosnt seem to work on linux let me quickly investigate further

This could be me changing the to_str to as_str. I couldn't seem to get it to build without this change on my end. But again, I know nothing about rust so could just have the toolchain setup wrong. I'm using rust 1.76.0.

arctixdev commented 4 months ago

Sorry for the long wait! I have been completely off this project for a while. I rewrote some of the rust code now and yeah to_str was definetly wrong.

ScriptType commented 4 months ago

The aarch64.dmg is still broken, x64 seems to work :/.

bbrendon commented 4 months ago

Is there a way to fix it manually? Right now opening says its broken and to move it to the trash.

arctixdev commented 4 months ago

Hmm I don't really know... sorry. I have never daily driven MacOS... Does it give any information about what is broken? Does it give you logs or something?

angelnu commented 4 months ago

I think it is related to the signature -

image

It can be circumvented with sudo xattr -rd com.apple.quarantine /Applications/Music\ Assistant\ Companion.app

I am not sure if there is a better way that does not require paying 99$/year to to register as Apple developer.

arctixdev commented 4 months ago

Actually we just bought a developer account so we just have to set up the signing to get it working then!

bbrendon commented 4 months ago

@angelnu That did it!!

arctixdev commented 4 months ago

The newer versions are signed, meaning this workaround no longer is needed

angelnu commented 4 months ago

it works!