search

music-assistant / hass-music-assistant

Turn your Home Assistant instance into a jukebox, hassle free streaming of your favorite media to Home Assistant media players.
Apache License 2.0
1.21k stars 43 forks source link

Local artwork doesn't show in HA Media Browser if remotely connected to HA #2045

Open vcdx71 opened 3 months ago

vcdx71 commented 3 months ago

What version of Music Assistant has the issue?

2.0.0B118

What version of the Home Assistant Integration have you got installed?

2024.3.4

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

The problem

Using the standard Home Assistant Media Player Card.

Choosing and playing a song displays the artwork as expected on the card. However, when the next song in the album plays the artwork is gone. If I manually start playing the same song the artwork displays correctly.

If an album is played artwork never shows up.

If an artist is played artwork for every song displays correctly.

The behavior was the same in B117. Can't comment on previous version as I switched from Plex to Remote Files, though I did not experience this issue with the Plex provider.

How to reproduce

Play songs, albums, and artists either through the Music Assistant interface or via a Home Assistant media browser on the media player card and observe the above artwork weirdness.

Music Providers

Only Remote Files

Player Providers

ChromeCast, AirPlay, and DNLA.

Full log output

ma.log

Additional information

Artwork is embedded in each file and also in a folder.jpg in each album directory.

What version of Home Assistant Core are your running

2024.3.1

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

marcelveldt commented 3 months ago

Thanks for the very clear bug report, I'll look into it!

vcdx71 commented 3 months ago

Thanks! From the triage it looks like this a HA Integration issue. Can I tack on to that? In the HA media browser Artists artwork shows but when getting to the Album level, none are showing, doesn't matter if I go to Artists or directly to Albums.

image

image

S1M8N commented 2 months ago

Same in playlist section

marcelveldt commented 2 months ago

this should be fixed with MA server 2.20.0 b146 + HA integration 2024.5.0 which are just released.

vcdx71 commented 2 months ago

Thanks looks like the media player is displaying artwork correctly now.

I am though now seeing no artwork for artists or albums. image image

OzGav commented 2 months ago

I see some artists and a handful of albums

marcelveldt commented 2 months ago

Does the artwork show up in the MA interface ? Are these local items or streaming providers ?

vcdx71 commented 2 months ago

They are local and they show perfectly in the MA interface.

marcelveldt commented 3 weeks ago

I finally had some time to dig into this issue. Is it true that the images only do not work if you are accessing HA on its remote URL ?

OzGav commented 3 weeks ago

I can recreate this and with the local IP URL (http://192.168.1.166:8123/) I don't see any album thumbs. Artist thumbs are OK (minus the disappearing ones subject to a separate report)

vcdx71 commented 3 weeks ago

I finally had some time to dig into this issue. Is it true that the images only do not work if you are accessing HA on its remote URL ?

Hadn't tested it that way, but yes you're correct. Artwork loads when accessing via IP, I usually use a cloudflare tunnel.

marcelveldt commented 3 weeks ago

I can recreate this and with the local IP URL (http://192.168.1.166:8123/) I don't see any album thumbs. Artist thumbs are OK (minus the disappearing ones subject to a separate report)

Yeah, that is what I suspected. Looks like I need to do some special magic handling to translate the urls.

marcelveldt commented 3 weeks ago

Unfortunately this is not possible without

a) a lot of work - its not as straightforward as expected b) impact on speed

As the HA mediabrowser is not our main priority (its lacking lots of features anyways) I'm not going to invest hours of work in this now while other more urgent issues are open.

I'm going to propose a change in the HA api to make this easier to work with.

I will leave this one open here to pickup on a rainy day.

For reference: Local artwork (as in: on your local disk/network) will NOT show up in the HA MediaBrowser if you are connecting to HA using an external URL.